Added support for proxy, updated packages and more. #21
Conversation
vnysheoran
requested review from
dreich-nucleus,
goeverest,
mateusfreira and
testbetter
mateusfreira
left a comment
mateusfreira
left a comment
There was a problem hiding this comment.
LGMT, thanks for the PR
dreich-nucleus
left a comment
dreich-nucleus
left a comment
There was a problem hiding this comment.
Small cleanup and I would like to know what inline does
|
Addressed Changes requested by @dreich-nucleus |
dreich-nucleus
left a comment
dreich-nucleus
left a comment
There was a problem hiding this comment.
The tags handling does not seem correct and you did not mention it in the PR description. I can't tell what I'm supposed to review here. But there are clearly bugs and changes needed.
| const config = loadYamlFile(filePath); | ||
| describe(filePath, () => { | ||
| let tagsInTest = []; | ||
| if (tagsInTest) { |
There was a problem hiding this comment.
This is always true. Empty arrays are not "falsey". So, this block always executes. Just remove the if.
Unless you meant to check something that might be false - like the config.apiCalls.tag or tagsArray.length (remember tagArray will be truthy even when empty).
| } | ||
| if (tagsArray.length > 0) { | ||
| let tagMatched = false; | ||
| for (const tagInArgs of tagsArray) { |
There was a problem hiding this comment.
Use lodash and one of its many set operators here - intersection is probably the one you want.
Added these two new flags in command-line arguments
Content-length set to Zero when the body is empty.