Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Empty Test Suites #20

Closed

Conversation

RehanSaeed
Copy link
Contributor

Fixes #19

@RehanSaeed
Copy link
Contributor Author

@ethomson How does this look?

@ethomson
Copy link
Member

Thanks for the fix and the useful tests. There were some conflicts, so I merged this manually.

@ethomson ethomson closed this Jan 25, 2023
@lukestoward
Copy link

lukestoward commented Feb 8, 2023

I've just tried out the new v2.1 release that includes this fix, but I think there is another case not catered for here.

For Go based projects we use go-junit-report to transform the testing output into JUnit. If a project doesn't have any tests, the output ends up as the following:

<?xml version="1.0" encoding="UTF-8"?>
<testsuites></testsuites>

I suspect this is because Go doesn't support self closing XML tags. Regardless, the above output still triggers the error unknown test file type for 'results.xml'. @RehanSaeed would it be possible to also cater for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An Empty Test File Causes an Error
3 participants