Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Adding 2023-10-01 to public repo #3105

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

[Test] Adding 2023-10-01 to public repo #3105

wants to merge 29 commits into from

Conversation

keryul
Copy link

@keryul keryul commented Nov 30, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

raych1 and others added 28 commits September 13, 2023 06:39
* Rename bug.md to bug_report.md

* Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Swagger Generation Artifacts

️🔄~[NotRequired_Staging] ApiDocPreview inProgress [Detail]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.4` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-hybridnetwork [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-hybridnetwork [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/hybridnetwork/armhybridnetwork [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.4` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️hybridnetwork [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from b8c73f963314f9ef6d59e6393cb6c1240a4257c7. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.hybridnetwork.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.hybridnetwork.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridnetwork/armhybridnetwork There is no API change compared with the previous version
Swagger Microsoft.HybridNetwork There is no API change compared with the previous version

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 1 Errors, 21 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
common.json 2023-10-01(d4275d5) 2023-09-01(main)
common.json 2023-10-01(d4275d5) 2022-01-01-preview(main)
configurationGroupSchema.json 2023-10-01(d4275d5) 2023-09-01(main)
configurationGroupValues.json 2023-10-01(d4275d5) 2023-09-01(main)
networkFunction.json 2023-10-01(d4275d5) 2023-09-01(main)
networkFunction.json 2023-10-01(d4275d5) 2022-01-01-preview(main)
networkFunctionDefinition.json 2023-10-01(d4275d5) 2023-09-01(main)
networkServiceDesign.json 2023-10-01(d4275d5) 2023-09-01(main)
operation.json 2023-10-01(d4275d5) 2023-09-01(main)
operation.json 2023-10-01(d4275d5) 2022-01-01-preview(main)
publisher.json 2023-10-01(d4275d5) 2023-09-01(main)
pureProxyArtifact.json 2023-10-01(d4275d5) 2023-09-01(main)
site.json 2023-10-01(d4275d5) 2023-09-01(main)
siteNetworkService.json 2023-10-01(d4275d5) 2023-09-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1011 - AddingResponseCode The new version adds a response code '200'.
New: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L107:11


The following breaking changes are detected by comparison with latest preview version:

Rule Message
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedApplicationParameters' removed or renamed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L509:3
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L391:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SubResource' removed or renamed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L509:3
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L391:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VendorProvisioningState' removed or renamed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L509:3
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L391:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SkuType' removed or renamed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L509:3
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L391:3
⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L513:9
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L395:9
⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L534:5
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L417:5
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'device' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'skuName' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'skuType' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'vendorName' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'serviceKey' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'vendorProvisioningState' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managedApplication' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managedApplicationParameters' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'networkFunctionContainerConfigurations' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'networkFunctionUserConfigurations' renamed or removed?
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'configurationType' that was not found in the old version.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L541:7
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L420:7
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'configurationType' that was not found in the old version.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L513:9
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L395:9
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'configurationType' that was not found in the old version.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L534:5
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L417:5
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L44:9
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L48:11
⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L364:9
Old: Microsoft.HybridNetwork/preview/2022-01-01-preview/networkFunction.json#L342:11
️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-10-01 package-2023-10-01(d4275d5) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L83
RPC-Delete-V1-01


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L38
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L239
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HybridNetwork/stable/2023-10-01/networkFunction.json#L358
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.HybridNetwork/stable/2023-10-01/publisher.json#L280
ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
Location: Microsoft.HybridNetwork/stable/2023-10-01/pureProxyArtifact.json#L176
NestedResourcesMustHaveListOperation The nested resource 'ProxyArtifactVersionsListOverview' does not have list operation, please add it.
Location: Microsoft.HybridNetwork/stable/2023-10-01/pureProxyArtifact.json#L247
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.HybridNetwork/stable/2023-10-01/siteNetworkService.json#L209
⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
Location: Microsoft.HybridNetwork/stable/2023-10-01/common.json#L223
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L52
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L55
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L91
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L100
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L103
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L125
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L147
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L156
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L159
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L187
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L209
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L218
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L221
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L234
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L252
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L261
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L264
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L286
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L306
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridNetwork/stable/2023-10-01/configurationGroupSchema.json#L309
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Hi @keryul! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants