Skip to content

Conversation

@jrbeilke
Copy link

Yet another PR to add use_internal_docker_network feature based on @amalucelli's work in #304 as well as @AaronKalair's work in #283

Modified the container_ip method to fetch the container's .IPAddress from .NetworkSettings.Networks using docker inspect as recommended by @rs017991 and https://docs.docker.com/engine/reference/commandline/inspect/#examples

This resolves #215

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #313 into master will decrease coverage by 0.99%.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
- Coverage   33.77%   32.78%   -1%     
=======================================
  Files           2        2           
  Lines         228      241   +13     
=======================================
+ Hits           77       79    +2     
- Misses        151      162   +11
Impacted Files Coverage Δ
lib/kitchen/driver/docker.rb 31.46% <14.28%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6075eb3...24f91c7. Read the comment docs.

@tas50
Copy link
Member

tas50 commented Jan 18, 2019

This same functionality has been merged to master and I'll be shipping it ASAP

@tas50 tas50 closed this Jan 18, 2019
@paulcalabro paulcalabro mentioned this pull request Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't login in docker when test-kitchen is executed from docker container

4 participants