use original gem #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebluber
approved these changes
Dec 2, 2020
Contributor
Author
|
@thebluber i added a monkey patch as the bug fix for json-api-client otherwise our tests were not passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the original gem. I have already sent the fix JsonApiClient/json_api_client#372. The maintainer told me it will be merged by tomorrow
I was using my forked copy in meantime but it looks like gem does not allow adding dependency directly from a github repo. So we have to live with the original gem with the bug
Once my PR gets merged, I will update the original gem here