Modernize code for renderers and remove filename conversion for Windows #4330
+18
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
commented
Oct 22, 2024
There was a problem hiding this comment.
The code in hocrrenderer.cpp was already modernized in commit db9c7e0.
egorpugin
approved these changes
Oct 22, 2024
|
For the future changes: is it possible to return unique ptr directly from upd.: This is general possible refactoring for all functions with similar behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit db52047 added the filename conversion for the hOCR renderer, but it was removed later for TSV in commit 6700edd.
Tesseract does not use a filename conversion anywhere else, so remove it for the other renderers, too.