Update hocrrenderer.cpp for solving the issue #4045 #4138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve the issue of Tesseract's hOCR output not displaying as XHTML in Chrome, modifications were made in the hocrrenderer.cpp file. These changes ensure proper generation of hOCR markup, including text direction and baseline information, allowing Chrome to correctly render the output as expected in an XHTML format.
stweil
requested changes
Oct 5, 2023
src/api/hocrrenderer.cpp
Outdated
|
|
||
| return true; | ||
| return true; |
There was a problem hiding this comment.
Please check why the indentation in your pull request changed. Maybe your editor inserted tabs or additional blanks?
There was a problem hiding this comment.
I have fixed the indentation at line 526. PLease review and merge my PR.
There was a problem hiding this comment.
The other lines still have a wrong indentation.
There was a problem hiding this comment.
I have commit the changes in the code , please review and give your review.
stweil
reviewed
Oct 5, 2023
src/api/hocrrenderer.cpp
Outdated
Comment on lines
506
to
526
| "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" | ||
| "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n" | ||
| " \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n" | ||
| "<html xmlns=\"http://www.w3.org/1999/xhtml\" xml:lang=\"en\" " | ||
| "lang=\"en\">\n <head>\n <title>"); | ||
| AppendString(title()); | ||
| AppendString( | ||
| "</title>\n" | ||
| " <meta http-equiv=\"Content-Type\" content=\"text/html;" | ||
| "charset=utf-8\"/>\n" | ||
| " <meta name='ocr-system' content='tesseract " TESSERACT_VERSION_STR | ||
| "' />\n" | ||
| " <meta name='ocr-capabilities' content='ocr_page ocr_carea ocr_par" | ||
| " ocr_line ocrx_word ocrp_wconf"); | ||
| if (font_info_) { | ||
| AppendString(" ocrp_lang ocrp_dir ocrp_font ocrp_fsize"); | ||
| } | ||
| AppendString( | ||
| "'/>\n" | ||
| " </head>\n" | ||
| " <body>\n"); |
There was a problem hiding this comment.
Suggested change
| "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" | |
| "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n" | |
| " \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n" | |
| "<html xmlns=\"http://www.w3.org/1999/xhtml\" xml:lang=\"en\" " | |
| "lang=\"en\">\n <head>\n <title>"); | |
| AppendString(title()); | |
| AppendString( | |
| "</title>\n" | |
| " <meta http-equiv=\"Content-Type\" content=\"text/html;" | |
| "charset=utf-8\"/>\n" | |
| " <meta name='ocr-system' content='tesseract " TESSERACT_VERSION_STR | |
| "' />\n" | |
| " <meta name='ocr-capabilities' content='ocr_page ocr_carea ocr_par" | |
| " ocr_line ocrx_word ocrp_wconf"); | |
| if (font_info_) { | |
| AppendString(" ocrp_lang ocrp_dir ocrp_font ocrp_fsize"); | |
| } | |
| AppendString( | |
| "'/>\n" | |
| " </head>\n" | |
| " <body>\n"); | |
| "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" | |
| "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\n" | |
| " \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n" | |
| "<html xmlns=\"http://www.w3.org/1999/xhtml\" xml:lang=\"en\" " | |
| "lang=\"en\">\n <head>\n <title>"); | |
| AppendString(title()); | |
| AppendString( | |
| "</title>\n" | |
| " <meta http-equiv=\"Content-Type\" content=\"text/html;" | |
| "charset=utf-8\"/>\n" | |
| " <meta name='ocr-system' content='tesseract " TESSERACT_VERSION_STR | |
| "' />\n" | |
| " <meta name='ocr-capabilities' content='ocr_page ocr_carea ocr_par" | |
| " ocr_line ocrx_word ocrp_wconf"); | |
| if (font_info_) { | |
| AppendString(" ocrp_lang ocrp_dir ocrp_font ocrp_fsize"); | |
| } | |
| AppendString( | |
| "'/>\n" | |
| " </head>\n" | |
| " <body>\n"); |
To resolve the issue of Tesseract's hOCR output not displaying as XHTML in Chrome, modifications were made in the hocrrenderer.cpp file. These changes ensure proper generation of hOCR markup, including text direction and baseline information, allowing Chrome to correctly render the output as expected in an XHTML format.
stweil
requested changes
Oct 5, 2023
src/api/hocrrenderer.cpp
Outdated
Comment on lines
503
to
504
| SetContentType("application/xhtml+xml"); | ||
| return true; |
There was a problem hiding this comment.
I don't understand this code. Where is SetContentType defined? And why do you add a return statement which makes the following code useless?
The modifications in hocrrenderer.cpp aim to address a rendering issue in Tesseract's hOCR output, ensuring it conforms to XHTML standards. These changes enable proper text direction and baseline information, resulting in correct display in Chrome.
This code addresses the issue by ensuring Tesseract's hOCR output complies with XHTML standards. It includes necessary metadata and formatting for text direction and baseline information, enabling correct rendering in web browsers like Chrome, ultimately resolving the rendering issue (tesseract-ocr#4045).
|
Please test your code changes locally before sending a pull request. All build tests fail because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue of Tesseract's hOCR output not displaying as XHTML in Chrome, modifications were made in the hocrrenderer.cpp file. These changes ensure proper generation of hOCR markup, including text direction and baseline information, allowing Chrome to correctly render the output as expected in an XHTML format.