Add an action output for cache size#30
Merged
jackieli-tes merged 1 commit intotespkg:mainfrom Jun 30, 2023
tvthatsme:output-cache-size
Merged
Add an action output for cache size#30jackieli-tes merged 1 commit intotespkg:mainfrom tvthatsme:output-cache-size
jackieli-tes merged 1 commit intotespkg:mainfrom
tvthatsme:output-cache-size
Conversation
Contributor
|
Hi, Thanks, this looks simple and straight forward improvement. |
Contributor
Author
|
Hey @jackieli-tes thanks for merging this! Would you mind cutting a release so that we could start using it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I'm seeing some cache-hits that are basically empty?
22 bytes when something like 537680268 bytes are really expected...
This leads to a positive cache hit and the rest of my workflow continues as if the cache object has been restored when it really wasn't in the s3 bucket at all. Later in the workflow everything fails when if I had known the hit was incorrect, I could have build the asset in the workflow.
These changes add a
cache-sizeoutput to the action so that other steps can decide if they want to trust a cache hit.Fix Issues