Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Retry-After header on 429 response code #3943

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

jlestel
Copy link
Contributor

@jlestel jlestel commented Jun 6, 2024

As seen in this ticket and in the @brianmay related PR, the API response code 429 contains a Retry-After header which must be respected to avoid unnecessary calls.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 2b7088e
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66623dff6edbc30008564b9b
😎 Deploy Preview https://deploy-preview-3943--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Julien added 2 commits June 7, 2024 00:51
@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Jun 7, 2024
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

@JakobLichterfeld JakobLichterfeld merged commit b900a98 into teslamate-org:master Jun 7, 2024
12 checks passed
@brianmay brianmay mentioned this pull request Jun 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants