Skip to content

Use Object.defineProperty to extend prototypes #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Object.defineProperty to extend prototypes #106

wants to merge 1 commit into from

Conversation

majgaard
Copy link

Extending the Array prototype by assignment causes unexpected behavior when iterating via the in operator.

CodePen with example

Instead, Object.defineProperty with enumerable: false should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@majgaard