Dataset Decompression Improvements #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation for delaying the decompression? From what I can tell, it's to allow the pgoress bar? At least for compressed tarfiles, this has the side-effect of needing to decompress the entire file twice, which can get pretty expensive. I also suspect that tarfile is smart enough that it won't re-scan the entire file if the next record the requested file. But This might be worth double checking. IIRC, zip files don't have either of these problems, due to how the file metadata is stored. |
|
Motivation is to avoid reopening a tar file for every file requested. I'm pretty sure tarfiles arent random access - they were designed for tapes... |
|
Ahhh, okay, now I get what this is doing. Yes, this is way better than before. |
seanmacavaney
changed the title
seanmacavaney
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comments as per commit messages