Skip to content

Fix tabs component active tab#750

Merged
ice1080 merged 2 commits intomainfrom
isaac/tab-tooltip
Mar 4, 2026
Merged

Fix tabs component active tab#750
ice1080 merged 2 commits intomainfrom
isaac/tab-tooltip

Conversation

@ice1080
Copy link
Contributor

@ice1080 ice1080 commented Mar 3, 2026

Adding the tooltip around the MuiTab caused the Active Tab to no longer display. Fix this by moving the tooltip to the label itself, except for disabled tabs (which can't be active anyway).

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web-components Ready Ready Preview, Comment Mar 4, 2026 5:15pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

To increment version on merge, please add one of patch (default), minor, or major label to this PR.

@github-actions github-actions bot added the patch label Mar 3, 2026
Copy link
Contributor Author

ice1080 commented Mar 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

ice1080 commented Mar 4, 2026

Merge activity

  • Mar 4, 5:37 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 4, 5:38 PM UTC: @ice1080 merged this pull request with Graphite.

@ice1080 ice1080 merged commit dcef8ec into main Mar 4, 2026
4 checks passed
@ice1080 ice1080 deleted the isaac/tab-tooltip branch March 4, 2026 17:38
ice1080 added a commit to terraware/terraware-web that referenced this pull request Mar 4, 2026
Always show the Temporary Plots tab in the survival rate settings. If there are no temporary plots available, disable the tab and display a tooltip explaining why it is disabled.

This is now waiting on terraware/web-components#750 to fix the Active Tab display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants