chore: speed up ci jobs #2237
Merged
chore: speed up ci jobs #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
23d7acb to
4798329
Compare
|
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
4798329 to
0ee2e85
Compare
Preview of ubuntu/go tests in 9e486cf🔍 View Details on Terramate Cloud .
|
Preview of macos-ventura/go tests in 9e486cf🔍 View Details on Terramate Cloud .
|
snakster
reviewed
Oct 27, 2025
mcalhoun
force-pushed
the
feat/mcalhoun/sc-15988/new-dependency-flags
branch
from
9cab623 to
154ec5b
Compare
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
0ee2e85 to
d97549e
Compare
mcalhoun
changed the base branch from
feat/mcalhoun/sc-15988/new-dependency-flags
to
graphite-base/2237
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
d97549e to
b7c3076
Compare
mcalhoun
force-pushed
the
graphite-base/2237
branch
from
154ec5b to
a2b9c15
Compare
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
b7c3076 to
8442d85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
2 times, most recently
from
804db89 to
7967643
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcalhoun
force-pushed
the
chore/mcalhoun/speed-up-ci-jobs
branch
from
7967643 to
9e486cf
Compare
| echo "result<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$(make bench/check 'new=${{ github.event.pull_request.head.sha }}' 'old=${{ github.event.pull_request.base.ref }}')" >> $GITHUB_OUTPUT | ||
| # Sort and combine all benchmark result files | ||
| find benchmark-results -name 'benchmark-result.txt' -type f | sort | while read -r result_file; do |
There was a problem hiding this comment.
Bug: Suppress Error Messages for Missing Directories
If the benchmark-results directory doesn't exist (e.g., when all benchmark jobs fail or download-artifact step fails despite continue-on-error), the find command will output an error message "find: 'benchmark-results': No such file or directory" which will be captured in GITHUB_OUTPUT and displayed in the PR comment. The command should check if the directory exists first, or redirect stderr to /dev/null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: parallelize benchmark workflow for faster execution
What this PR does / why we need it:
This PR enhances the benchmark workflow by parallelizing benchmark execution across packages. The changes include:
bench/checkmake target:countparameter (defaults to 20) to control benchmark iterationsparallelparameter (defaults to 1) to control Go test parallelismThese changes improve CI efficiency by running benchmarks for different packages concurrently rather than sequentially.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The workflow now automatically discovers packages with benchmark tests and runs them in parallel, which should significantly reduce the overall benchmark execution time.
Does this PR introduce a user-facing change?
No
Note
Parallelizes Go benchmarks per-package with matrix jobs, uploads results as artifacts, aggregates them into a single PR comment, and adds count/parallel options to bench/check.
.github/workflows/benchmark.yml):discoverjob to find packages containing benchmark functions.benchmarksper-package via matrix; generate package-scoped result files and upload as artifacts.reportjob to download, combine, and post aggregated benchmark results to the PR.makefiles/common.mk):bench/checkwithcountandparallelparameters (defaults:20,1).-paralleland dynamic-countthrough-go-test-flags.Written by Cursor Bugbot for commit 9e486cf. This will update automatically on new commits. Configure here.