-
Couldn't load subscription status.
- Fork 109
feat: git change detection works on any commit #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for terramate-io-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ab25e41 to
318124b
Compare
|
123e97a to
767bcf8
Compare
767bcf8 to
14158a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally tested the PR, please check the notion document for comments on a case this PR now creates wrong results when calculating changes.
14158a3 to
d6d7d1d
Compare
✅ Deploy Preview for docs-terramate-io canceled.
|
9b7088b to
c6895ee
Compare
ddfe460 to
99a1ed3
Compare
99a1ed3 to
39f0dd0
Compare
f9f3a79 to
9815ff7
Compare
9815ff7 to
d3f17fc
Compare
d3f17fc to
04e123d
Compare
04e123d to
3c0d658
Compare

Reason for This Change
Currently, the Git revision that's used for change comparison with
terramate (run | list) --changedis selected based on these rules (simplified):This means for the two cases of either getting a preview of a deployment, or executing the deployment, it will select the changed stacks relative to the previous deployment (w.r.t. to the commit graph).
For anything before origin/main, it will not select the changed stacks relative to the previous deployment, but the changed stacks compared to the latest deployment.
This is inconsistent, and more importantly, can lead to unintended behaviour in case of queued CI jobs that are behind origin/main when multiple PRs are merged in parallel.
Description of Changes
The selection logic for the compared base revision is changed so that "select the changed stacks relative to the previous deployment"-behaviour works on any commit.
Simplified, this means any commit is now compared its fork point from origin/main.