This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
Adding desired state #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passing
|
|
This is ready for another review @scross01 |
scross01
suggested changes
Jul 19, 2018
| @@ -61,7 +61,7 @@ The following arguments are supported: | |||
| * `default_access_rules` - (Optional) Specifies the details on which default access rules are enable or disabled. Default Access Rules | |||
| are configured below. | |||
|
|
|||
| * `desired_state` - (Optional) Specifies the desired state of the servie instance. Allowed values are `start`, `stop`, | |||
| * `desired_state` - (Optional) Specifies the desired state of the service instance. Allowed values are `start`, `stop`, | |||
There was a problem hiding this comment.
should change to running and shutdown
However, I just noticed we added the DB running state in v1.1.0, so this is already out there. Could we "deprecate" the use of start/stop (with a warning) and add running/shutdown as the preferred values.
There was a problem hiding this comment.
We should be able to migrate user's states over to a new format instead of deprecating but let's add that in the next release
| @@ -128,6 +128,8 @@ value is `PAAS`. | |||
| * `backup_destination` - (Optional) Specifies whether to enable backups for this Oracle Java Cloud Service instance. | |||
| Valid values are `BOTH` or `NONE`. Defaults to `BOTH`. | |||
|
|
|||
| * `desired_state` - (Optional) Specifies the desired state of the service instance. Allowed values are `start` or `stop`. | |||
There was a problem hiding this comment.
should be running and shutdown
scross01
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.