Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025

The rule contained typos in an existing instance type and comment.

Changes

  • Fixed typos:
    • db.x2idn.16xlargdb.x2idn.16xlarge
    • Comment: intanceinstance

Total instance types remain at 338 (unchanged).

All changes verified against AWS RDS documentation.

Original prompt

Please update rules/aws_db_instance_invalid_type.go
You can see the valid instance types from https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.Support.html


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 1, 2025
Copilot AI and others added 3 commits November 1, 2025 13:31
Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Copilot AI changed the title [WIP] Update valid instance types for AWS DB instances Update AWS RDS DB instance types to include 2024 instances Nov 1, 2025
Copilot AI requested a review from wata727 November 1, 2025 13:42
@wata727
Copy link
Member

wata727 commented Nov 1, 2025

@copilot The only compute-optimized resource is db.c6gd. db.i3 and db.i4i does not exist.
Please revert these changes except typo fixes. Also, please revert the changes for tests.

Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 1, 2025

@copilot The only compute-optimized resource is db.c6gd. db.i3 and db.i4i does not exist.
Please revert these changes except typo fixes. Also, please revert the changes for tests.

Reverted the incorrect instance types (c5, c6g, c7g, i3, i4i) and test changes. Kept only the typo fixes and db.c6gd.metal. Changes in commit 2e19274.

Copilot AI changed the title Update AWS RDS DB instance types to include 2024 instances Add missing db.c6gd.metal instance type and fix typos Nov 1, 2025
resourceType: "aws_db_instance",
attributeName: "instance_class",
instanceTypes: map[string]bool{
"db.c6gd.metal": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot db.c6gd.metal is not valid type. Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed db.c6gd.metal. Now only the two typo fixes remain. Changes in commit 04edb39.

Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Copilot AI changed the title Add missing db.c6gd.metal instance type and fix typos Fix typos in AWS RDS DB instance types Nov 1, 2025
Copilot AI requested a review from wata727 November 1, 2025 14:22
@wata727 wata727 marked this pull request as ready for review November 1, 2025 14:52
@wata727 wata727 enabled auto-merge (squash) November 1, 2025 14:52
@wata727 wata727 merged commit 6297af1 into master Nov 1, 2025
23 checks passed
@wata727 wata727 deleted the copilot/update-aws-db-instance-types branch November 1, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants