fix: update mappings for AWS Provider v6 compatibility #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove s3_settings from aws_dms_endpoint mapping and add aws_dms_s3_endpoint mapping to fix maintenance workflow failures with AWS Provider v6. In AWS Provider v6, the s3_settings attribute was removed from aws_dms_endpoint and a dedicated aws_dms_s3_endpoint resource was introduced for S3-specific DMS endpoints. This change updates the mappings accordingly and generates validation rules for the new resource. - Remove s3_settings from aws_dms_endpoint mapping - Add aws_dms_s3_endpoint mapping with S3-specific validation attributes - Update provider version constraint to ~> 6.0 - Generate new validation rules for aws_dms_s3_endpoint Fixes #899
Improve the generator to handle AWS Provider v6 schema differences gracefully: - Convert fetchSchema panics to proper error handling - Skip missing attributes with informative error messages - Allow generator to complete successfully despite schema mismatches - Remove deprecated attributes from EC2 mappings (vpc, cpu_core_count, cpu_threads_per_core) This enables the maintenance workflow to run successfully with AWS Provider v6 while providing clear feedback about incompatible mappings.
bendrucker
changed the title
Update the generator to handle AWS Provider v6 schema differences: - Replace panic calls with proper error handling that exits with status 1 - Remove deprecated attributes that no longer exist in AWS Provider v6: - aws_eip.vpc - aws_instance.cpu_core_count - aws_instance.cpu_threads_per_core - aws_launch_template.elastic_inference_accelerator - aws_launch_template.elastic_gpu_specifications This ensures the maintenance workflow fails gracefully with clear error messages when mappings are incompatible with the provider schema.
Remove all deprecated attributes and end-of-life services according to AWS Provider v6 migration guide. This resolves the maintenance workflow failures by ensuring all mappings are compatible with the v6.0 provider schema. Changes: - Remove aws_spot_instance_request.block_duration_minutes (deprecated) - Remove aws_eks_addon.resolve_conflicts (deprecated) - Remove aws_ssm_association.instance_id (deprecated) - Remove aws_flow_log.log_group_name (deprecated) - Remove aws_redshift_cluster.logging and snapshot_copy (deprecated) - Remove entire opsworks.hcl (service EOL May 2024) - Remove entire simpledb.hcl (not supported in AWS SDK v2) - Regenerate validation rules and resource lists Fixes #899
|
@bendrucker Thank you for working on this. Any blockers for this PR? |
|
I think this should basically be ready, I can pick this up today. The Smithy switch is somewhat more involved because of changes to the API spec that are potentially breaking. I got caught up in workarounds for that and I think just forgot to come back to this one. |
- Update terraform.lock.hcl to v6.5.0 - Regenerate provider schema with latest version - Add new resources to tags list: - aws_bedrockagent_flow - aws_kinesis_stream_consumer - aws_s3_directory_bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complete AWS Provider v6.0 compatibility migration for tflint-ruleset-aws. This PR addresses all breaking changes from the v6 migration guide.
Changes
DMS Resource Updates
s3_settingsfromaws_dms_endpointmapping (moved to dedicated resource in v6)aws_dms_s3_endpointmapping with 8 S3-specific validation attributesDeprecated Attribute Removals
aws_spot_instance_request.block_duration_minutesaws_eks_addon.resolve_conflictsaws_ssm_association.instance_idaws_flow_log.log_group_nameaws_redshift_cluster.loggingandsnapshot_copyEnd-of-Life Service Removals
Generator Improvements
Fixes #899