Remove deprecated IncludeNotCreated option (#274)

terraform-linters · Jul 29, 2023 · 069cad7 · 069cad7
1 parent ee6dcd7
commit 069cad7
Show file tree

Hide file tree

Showing 6 changed files with 332 additions and 356 deletions.
diff --git a/plugin/internal/fromproto/fromproto.go b/plugin/internal/fromproto/fromproto.go
@@ -267,10 +267,9 @@ func GetModuleContentOption(opts *proto.GetModuleContent_Option) tflint.GetModul
 	}
 
 	return tflint.GetModuleContentOption{
-		ModuleCtx:         ModuleCtxType(opts.ModuleCtx),
-		IncludeNotCreated: opts.IncludeNotCreated,
-		ExpandMode:        ExpandMode(opts.ExpandMode),
-		Hint:              GetModuleContentHint(opts.Hint),
+		ModuleCtx:  ModuleCtxType(opts.ModuleCtx),
+		ExpandMode: ExpandMode(opts.ExpandMode),
+		Hint:       GetModuleContentHint(opts.Hint),
 	}
 }
 

diff --git a/plugin/internal/plugin2host/plugin2host_test.go b/plugin/internal/plugin2host/plugin2host_test.go
@@ -651,10 +651,9 @@ volume_size = 10`)
 			Name: "get content with options",
 			Args: func() (*hclext.BodySchema, *tflint.GetModuleContentOption) {
 				return &hclext.BodySchema{}, &tflint.GetModuleContentOption{
-					ModuleCtx:         tflint.RootModuleCtxType,
-					IncludeNotCreated: true,
-					ExpandMode:        tflint.ExpandModeNone,
-					Hint:              tflint.GetModuleContentHint{ResourceType: "aws_instance"},
+					ModuleCtx:  tflint.RootModuleCtxType,
+					ExpandMode: tflint.ExpandModeNone,
+					Hint:       tflint.GetModuleContentHint{ResourceType: "aws_instance"},
 				}
 			},
 			ServerImpl: func(schema *hclext.BodySchema, opts tflint.GetModuleContentOption) (*hclext.BodyContent, hcl.Diagnostics) {
@@ -663,11 +662,6 @@ volume_size = 10`)
 						&hcl.Diagnostic{Severity: hcl.DiagError, Summary: "unexpected moduleCtx options"},
 					}
 				}
-				if !opts.IncludeNotCreated {
-					return &hclext.BodyContent{}, hcl.Diagnostics{
-						&hcl.Diagnostic{Severity: hcl.DiagError, Summary: "unexpected includeNotCreatedResources options"},
-					}
-				}
 				if opts.ExpandMode != tflint.ExpandModeNone {
 					return &hclext.BodyContent{}, hcl.Diagnostics{
 						&hcl.Diagnostic{Severity: hcl.DiagError, Summary: "unexpected expand mode options"},