Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds nonsensitive in for_each for sensitive value #183

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

maheshwarishikha
Copy link
Member

@maheshwarishikha maheshwarishikha commented Apr 4, 2024

Description

Adds nonsensitive in for_each for sensitive value
Issue: GoldenEye/issues/issues/8144

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Fix for sensitive values cannot be used as for_each arguments. Adds nonsensitive in for_each for sensitive value.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@maheshwarishikha
Copy link
Member Author

Found a gap in tests. Currently no test is testing this functionality. Tested locally, it is working fine.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

1 similar comment
@maheshwarishikha
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit e061b36 into main Apr 19, 2024
2 checks passed
@ocofaigh ocofaigh deleted the sm-8144 branch April 19, 2024 08:16
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants