fix: add new Addon tests #496
Conversation
|
/run pipeline |
|
/run pipeline |
rajatagarwal-ibm
left a comment
rajatagarwal-ibm
left a comment
There was a problem hiding this comment.
I think one more test case can be added:
- accounts disabled, and others are enabled.
Wondering if there's a way to find all possible combinations of the tests? Maybe we could create a small tool or something?
Yes this is on my TODO list already.
I think this is the default behaviour |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
| SkipInfrastructureDeployment: true, | ||
| }, | ||
| { | ||
| Name: "EN-With-KMS-Disabled", |
There was a problem hiding this comment.
This test should not be passing. The current Observability monolith requires KMS. So if you remove KMS, the Observability DA has a required input thats shows like this:
There was a problem hiding this comment.
In this test case, we explicitly pass the key line 531, as we expect the user to do this in that flow. Or do you think we should raise the key up to the top level and never have them go to the lower level configurations?
There was a problem hiding this comment.
I don't think consumer should ever have to go to the lower level configurations to fill in a required value. Only if they want to override a value. The problem here is that KMS is required for current Observability DA. And until we add a "Full configurable" variation - I think we have to mark KMS as required in Observability DA
There was a problem hiding this comment.
actually this is set at the top level which I think is the correct usage
|
🎉 This PR is included in version 2.4.15 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Adding addon tests exposed we needed to map the existing kms crn in observability for flows where kms was disabled
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers