Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ibm_iam_account_settings from da #751

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix: remove ibm_iam_account_settings from da #751

merged 3 commits into from
Oct 21, 2024

Conversation

Soaib024
Copy link
Member

@Soaib024 Soaib024 commented Oct 20, 2024

Description

#742
https://github.ibm.com/GoldenEye/issues/issues/11138

Parse existing_cos_instance_id which is required variable for both DA to get account id

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit fb0cc4d into main Oct 21, 2024
2 checks passed
@ocofaigh ocofaigh deleted the soaib-11138 branch October 21, 2024 12:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants