Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(template): Added option to set stack_type of instance_template #251

Merged

Conversation

danielgronberg
Copy link
Contributor

@danielgronberg danielgronberg commented Jul 7, 2022

BEGIN_COMMIT_OVERRIDE
feat(template)!: Added option to set stack_type of instance_template #251
END_COMMIT_OVERRIDE

@google-cla
Copy link

google-cla bot commented Jul 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@comment-bot-dev
Copy link

comment-bot-dev commented Jul 7, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 14, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @danielgronberg
Can we also bump the min provider version to 3.88 when this was added to the provider https://github.com/hashicorp/terraform-provider-google/blob/v3.90.1/CHANGELOG.md#3880-october-11-2021

@bharathkkb bharathkkb removed the Stale label Oct 18, 2022
@legal90
Copy link
Contributor

legal90 commented Nov 23, 2022

@bharathkkb The minimal provider version has been bumped. Could you please review this PR again?

@apeabody apeabody changed the title feat(template): Added option to set stack_type of instance_template feat!(template): Added option to set stack_type of instance_template Nov 28, 2022
@apeabody apeabody self-assigned this Nov 28, 2022
@apeabody apeabody requested a review from a team as a code owner November 30, 2022 15:34
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @danielgronberg!

@apeabody apeabody merged commit bf565b0 into terraform-google-modules:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants