-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(template): Added option to set stack_type of instance_template #251
feat!(template): Added option to set stack_type of instance_template #251
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for the PR! 🚀 |
e02bdb7
to
b9f28fe
Compare
b9f28fe
to
e3184da
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @danielgronberg
Can we also bump the min provider version to 3.88 when this was added to the provider https://github.com/hashicorp/terraform-provider-google/blob/v3.90.1/CHANGELOG.md#3880-october-11-2021
google = ">= 3.43, < 5.0" |
@bharathkkb The minimal provider version has been bumped. Could you please review this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @danielgronberg!
BEGIN_COMMIT_OVERRIDE
feat(template)!: Added option to set stack_type of instance_template #251
END_COMMIT_OVERRIDE