Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preemptible option to instance_template module #14

Merged

Conversation

namusyaka
Copy link
Contributor

As I talked about the preemptible module, I would like you to review this changes at first.
This change makes instance_template accept the preemptible variable

@morgante @aaron-lane

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit pyc files. (See test/verify_boilerplate.pyc.) We should probably add this to the .gitignore.

Otherwise LGTM, thanks!

@namusyaka
Copy link
Contributor Author

@morgante Yes, removed.
However, the test/verify_boilerplate.pyc has already been committed in this repository.
Is that just a mistake?

@morgante
Copy link
Contributor

morgante commented Jul 19, 2019

@namusyaka Yeah, looks like a mistake. Thanks!

@namusyaka namusyaka merged commit 52cf33f into terraform-google-modules:master Jul 19, 2019
@namusyaka namusyaka deleted the add-optional-pvm-flag branch July 19, 2019 06:45
aaron-lane added a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants