Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add iam permission required for vault version greater than 1.11 … #198

Merged
merged 5 commits into from
Jun 13, 2024
Merged

fix: Add iam permission required for vault version greater than 1.11 … #198

merged 5 commits into from
Jun 13, 2024

Conversation

dcb-imvaria
Copy link
Contributor

…(#184)

@dcb-imvaria dcb-imvaria requested a review from a team as a code owner November 8, 2023 22:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 7, 2024
@github-actions github-actions bot removed the Stale label Jan 8, 2024
@dcb-imvaria dcb-imvaria mentioned this pull request Mar 6, 2024
Closed
@airman604
Copy link

I also experienced the same issue trying to install Vault 1.16 and the proposed fix resolved the issue. Per https://support.hashicorp.com/hc/en-us/articles/5277291261075-Auto-unseal-using-GCP-Cloud-KMS#:~:text=2.-,credentials,-%3A%20This%20parameter only cloudkms.cryptoKeys.get permission is needed, but I think considering it's a key dedicated to Vault, using viewer is reasonable.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jun 5, 2024
@dcb-imvaria
Copy link
Contributor Author

The workflow is awaiting approval from the maintainer. Is a maintainer assigned?

@github-actions github-actions bot removed the Stale label Jun 6, 2024
@ianc769
Copy link

ianc769 commented Jun 12, 2024

+1 and maybe @g-awmalik or @apeabody ?

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Jun 13, 2024
@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dcb-imvaria!

@apeabody apeabody enabled auto-merge (squash) June 13, 2024 16:14
@apeabody apeabody merged commit 0e127ba into terraform-google-modules:master Jun 13, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcb-imvaria @airman604 @ianc769 @apeabody