feat: add support for server_ca_mode and custom SANs (#714) #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hostekevin
requested review from
ayushmjain,
imrannayer,
q2w and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…e-modules#714) Add support for configuring server_ca_mode and server_ca_pool in the PostgreSQL module's IP configuration. This enables custom certificate authority management for CloudSQL instances. Also add support for custom Subject Alternative Names (SANs) to allow custom DNS names to be included in the server certificate. This fixes an issue with cloud-sql-proxy version after 2.15.2 that fails to verify certificates when using custom domain names, as described in: GoogleCloudPlatform/cloud-sql-proxy#2425 Increase minimum Google provider version to 6.31.0, as the custom_subject_alternative_names field was introduced in this version: https://github.com/hashicorp/terraform-provider-google/releases/tag/v6.31.0
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuring server_ca_mode and server_ca_pool in the PostgreSQL module's IP configuration. This enables custom certificate authority management for CloudSQL instances.
Also add support for custom Subject Alternative Names (SANs) to allow custom DNS names to be included in the server certificate.
This fixes an issue with cloud-sql-proxy version after 2.15.2 that fails to verify certificates when using custom domain names, as described in: GoogleCloudPlatform/cloud-sql-proxy#2425
Increase minimum Google provider version to 6.31.0, as the
custom_subject_alternative_namesfield was introduced in this version: https://github.com/hashicorp/terraform-provider-google/releases/tag/v6.31.0