Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG >=5.33)!: zone_distribution_config force recreation #222

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

lanandra
Copy link
Contributor

Set default value for zone_distribution_config mode to MULTI_ZONE.

Refer to issue #220

set default value for zone_distribution_config mode to MULTI_ZONE
@lanandra lanandra requested review from imrannayer and a team as code owners July 10, 2024 07:03
Copy link

google-cla bot commented Jul 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lanandra lanandra changed the title fix - zone_distribution_config force recreation fix: zone_distribution_config force recreation Jul 10, 2024
@blueonrails
Copy link

Thanks for the PR, this bug is blocking us 👍

@imrannayer imrannayer self-assigned this Jul 15, 2024
@imrannayer imrannayer changed the title fix: zone_distribution_config force recreation feat(TPG >=5.33)!: zone_distribution_config force recreation Jul 15, 2024
@imrannayer
Copy link
Collaborator

@lanandra zone_distribution_config was added in 5.33. Can you plz change min provider version to 5.33 in versions.tf file? It will be a breaking change.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit c49bdbf into terraform-google-modules:master Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants