feat: added support for creating proxy only subnet #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawan1210
force-pushed
the
feat/create-proxy-only-subnet
branch
from
d4fba67 to
e97f914
Compare
pawan1210
requested review from
ayushmjain,
imrannayer,
q2w and
a team
as code owners
q2w
reviewed
Apr 17, 2025
modules/frontend/variables.tf
Outdated
| region = string | ||
| address = optional(string) | ||
| subnetwork = optional(string) | ||
| create_proxy_only_subnet = bool |
There was a problem hiding this comment.
Can we have a default value for this as false?
| @@ -200,11 +200,13 @@ variable "http_keep_alive_timeout_sec" { | |||
| } | |||
|
|
|||
| variable "internal_forwarding_rules_config" { | |||
| description = "List of internal managed forwarding rules config. One of 'address' or 'subnetwork' is required for each. It is only applicable for internal load balancer" | |||
| description = "List of internal managed forwarding rules config. One of 'address' or 'subnetwork' is required for each. If 'create_proxy_only_subnet' is true, 'proxy_only_subnet_ip' is required. It is only applicable for internal load balancer." | |||
There was a problem hiding this comment.
As mentioned here one of address and subnetwork can be configured. Can we have a validation block for this input variable to validate exactly this?
|
/gcbrun |
q2w
reviewed
Apr 21, 2025
modules/frontend/main.tf
Outdated
| @@ -43,6 +43,22 @@ locals { | |||
| first_backend_service = try(local.backend_services_by_host[local.first_host][local.first_path], null) | |||
| } | |||
|
|
|||
| resource "google_compute_subnetwork" "proxy_only" { | |||
| for_each = { | |||
| for index, config in var.internal_forwarding_rules_config : index => config | |||
There was a problem hiding this comment.
Could you use region as key to remove risk of recreation because of order change? This is similar to how it has been done when creating forwarding rules for internal_forwarding_rules_config.
…nal_forwarding_rules_config variable
pawan1210
force-pushed
the
feat/create-proxy-only-subnet
branch
from
8b7114b to
7355458
Compare
q2w
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.