Fix for Ensure that GA modules don't depend on beta functionality #181 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankorn
reviewed
Aug 12, 2019
There was a problem hiding this comment.
@kopachevsky, do we need to remove provider definition in examples or or just update it with stable?
ivankorn
reviewed
Aug 13, 2019
paulpalamarchuk
suggested changes
Aug 14, 2019
autogen/cluster_regional.tf
Outdated
| @@ -193,7 +193,11 @@ resource "google_container_cluster" "primary" { | |||
| Create regional node pools | |||
| *****************************************/ | |||
| resource "google_container_node_pool" "pools" { | |||
| {% if private_cluster or beta_cluster %} | |||
There was a problem hiding this comment.
Do we need beta for "private_cluster" ?
There was a problem hiding this comment.
no, will check this remaining one
ingwarr
previously approved these changes
Aug 14, 2019
paulpalamarchuk
previously approved these changes
Aug 15, 2019
ingwarr
previously approved these changes
Aug 15, 2019
kopachevsky
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
kopachevsky
dismissed stale reviews from ingwarr and paulpalamarchuk
via
6492b45
|
@morgante something wrong with this PR, workload-metadata-config failing with terraform crash, investigating why |
|
False alarm, issue in previously merged PR |
ingwarr
approved these changes
Aug 16, 2019
paulpalamarchuk
previously approved these changes
Aug 20, 2019
ingwarr
previously approved these changes
Aug 20, 2019
|
@kopachevsky |
ivankorn
suggested changes
Aug 20, 2019
There was a problem hiding this comment.
@kopachevsky
Should we wait for integration tests to start passing ?
https://concourse.infra.cft.tips/builds/6551
kopachevsky
dismissed stale reviews from ingwarr and paulpalamarchuk
via
4b2c0f3
aaron-lane
suggested changes
Aug 26, 2019
Beta functionality removed fully from public and private cluster modules and related exampled. As long node_pool example used taints that in beta, it switched to public-cluster-beta module from root one. * Fixes #181
morgante
approved these changes
Aug 28, 2019
morgante
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181