Skip to content

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Nov 1, 2021

Overview

The official version of GitHub OpenID connection no longer requires audience=sigstore. So, the default value of allowed_audiences can be an empty list.
https://docs.github.com/ja/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform

@google-cla
Copy link

google-cla bot commented Nov 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@comment-bot-dev
Copy link

comment-bot-dev commented Nov 1, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@yu-iskw yu-iskw marked this pull request as ready for review November 1, 2021 04:32
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yu-iskw
We just need to update the tests here

assert.Equal(1, len(provider.Get("oidc.allowedAudiences").Array()), "WI provider has correct number of audiences")
assert.Equal("sigstore", provider.Get("oidc.allowedAudiences").Array()[0].String(), "WI provider has correct audience")

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Nov 4, 2021

Ok. I will fix it.

@bharathkkb bharathkkb merged commit 1ec0ec2 into terraform-google-modules:master Nov 9, 2021
@release-please release-please bot mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants