Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MIG example to use Terraform v0.12 compatible modules #28

Closed
aaron-lane opened this issue Jun 10, 2019 · 7 comments · Fixed by #41
Closed

Update MIG example to use Terraform v0.12 compatible modules #28

aaron-lane opened this issue Jun 10, 2019 · 7 comments · Fixed by #41
Assignees
@ivankorn
Labels
blocked-0.12 enhancement New feature or request Stale

Comments

@aaron-lane
Copy link
Contributor

No description provided.

@aaron-lane aaron-lane added enhancement New feature or request blocked-0.12 labels Jun 10, 2019
@ivankorn
Copy link
Contributor

terraform validate fails on that: output
#32

This was referenced Aug 14, 2019
Closed
Closed
@ivankorn ivankorn self-assigned this Aug 14, 2019
This was referenced Aug 16, 2019
Closed
Closed
@ivankorn
Copy link
Contributor

This issue is blocked by 0.12 support for following 2 modules:

@morgante
Copy link
Contributor

@ivankorn You can replace the MIG with this module: https://github.com/terraform-google-modules/terraform-google-vm/tree/master/modules/mig

@ivankorn
Copy link
Contributor

Great! Thank you, @morgante !

ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
ebf1c72 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)
@ivankorn ivankorn mentioned this issue Aug 19, 2019
Closed
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
70a0da8 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
3fe1ebe 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf with adding hashed image into instance_name
- Updated examples/simple_instance/outputs.tf with adding hashed image into instance_name
@ivankorn ivankorn mentioned this issue Aug 19, 2019
Merged
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
1936ae6 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
cdc9ec7 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
221f9d7 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 20, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
67b616e 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master
- Adjusted .gitingore

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 20, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
185ec55 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master
- Adjusted .gitingore

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Sep 11, 2019
@ivankorn
Migrated MIG example to TF 0.12 syntax and compatible modules
4ff9f7f 
ref: terraform-google-modules#28

```
[/workspace/google/terraform-google-container-vm/examples/managed_instance_group]$ terraform apply -auto-approve
module.gce-container.data.external.spec_as_yaml: Refreshing state...
module.mig.data.google_compute_zones.available: Refreshing state...
module.mig_template.data.google_compute_image.image_family: Refreshing state...
module.gce-container.data.google_compute_image.coreos: Refreshing state...
module.mig_template.data.google_compute_image.image: Refreshing state...
module.cloud-nat.random_string.name_suffix: Creating...
module.http-lb.google_compute_global_address.default: Creating...
module.cloud-nat.random_string.name_suffix: Creation complete after 0s [id=725bw2]
module.http-lb.google_compute_http_health_check.default[0]: Creating...
google_compute_network.default: Creating...
google_compute_firewall.lb-to-instances: Creating...
module.http-lb.google_compute_http_health_check.default[0]: Creation complete after 5s [id=mig-test-lb-backend-0]
module.http-lb.google_compute_global_address.default: Creation complete after 5s [id=mig-test-lb-address]
google_compute_network.default: Still creating... [10s elapsed]
google_compute_firewall.lb-to-instances: Still creating... [10s elapsed]
google_compute_firewall.lb-to-instances: Creation complete after 18s [id=mig-test-firewall-lb-to-instances]
google_compute_network.default: Still creating... [20s elapsed]
google_compute_network.default: Creation complete after 28s [id=mig-net]
google_compute_router.default: Creating...
google_compute_subnetwork.default: Creating...
module.http-lb.google_compute_firewall.default-hc[0]: Creating...
google_compute_router.default: Creation complete after 5s [id=us-east4/mig-net-gw-group1]
module.cloud-nat.google_compute_router_nat.main: Creating...
google_compute_subnetwork.default: Still creating... [10s elapsed]
module.http-lb.google_compute_firewall.default-hc[0]: Still creating... [10s elapsed]
module.cloud-nat.google_compute_router_nat.main: Still creating... [10s elapsed]
module.http-lb.google_compute_firewall.default-hc[0]: Creation complete after 17s [id=mig-test-lb-hc-0]
google_compute_subnetwork.default: Still creating... [20s elapsed]
module.cloud-nat.google_compute_router_nat.main: Creation complete after 17s [id=us-east4/mig-net-gw-group1/mig-net-cloud-nat-group1]
google_compute_subnetwork.default: Creation complete after 30s [id=us-east4/mig-net]
module.mig_template.google_compute_instance_template.tpl: Creating...
module.mig_template.google_compute_instance_template.tpl: Creation complete after 4s [id=mig-net-20190911232353889100000001]
module.mig.google_compute_region_instance_group_manager.mig: Creating...
module.mig.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed]
module.mig.google_compute_region_instance_group_manager.mig: Creation complete after 20s [id=gl-ivankorniienko-seed-251912/us-east4/mig-net-mig]
module.http-lb.google_compute_backend_service.default[0]: Creating...
module.http-lb.google_compute_backend_service.default[0]: Creation complete after 8s [id=mig-test-lb-backend-0]
module.http-lb.google_compute_url_map.default[0]: Creating...
module.http-lb.google_compute_url_map.default[0]: Creation complete after 5s [id=mig-test-lb-url-map]
module.http-lb.google_compute_target_http_proxy.default[0]: Creating...
module.http-lb.google_compute_target_http_proxy.default[0]: Creation complete after 4s [id=mig-test-lb-http-proxy]
module.http-lb.google_compute_global_forwarding_rule.http[0]: Creating...
module.http-lb.google_compute_global_forwarding_rule.http[0]: Still creating... [10s elapsed]
module.http-lb.google_compute_global_forwarding_rule.http[0]: Creation complete after 18s [id=mig-test-lb]

Apply complete! Resources: 15 added, 0 changed, 0 destroyed.

Outputs:

container = {
  "image" = "gcr.io/google-samples/hello-app:1.0"
}
http_address = 34.102.132.47
http_port = 80
project_id = gl-ivankorniienko-seed-251912
vm_container_label = cos-stable-76-12239-60-0
volumes = []
```
@ivankorn ivankorn mentioned this issue Sep 11, 2019
Merged
@captain-kark
Copy link

This is still reported as a "Known Issue" in the readme file.

@morgante morgante reopened this Dec 2, 2019
@uhinze
Copy link

uhinze commented Jan 29, 2020

Also it looks like 0.10 is the only supported version, could be changed while at it.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 30, 2021
@github-actions github-actions bot closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivankorn ivankorn

Labels
blocked-0.12 enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrated MIG example to TF 0.12 syntax and compatible modules ivankorn/terraform-google-container-vm
5 participants
@morgante @aaron-lane @uhinze @captain-kark @ivankorn