Refactor cloud build deploy instructions #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
requested review from
a team,
rjerrems and
bharathkkb
as code owners
bharathkkb
reviewed
Oct 12, 2022
There was a problem hiding this comment.
Thanks @daniel-cit a few comments but most LGTM. I also think we are missing a repo iam permissions in 5-app-infra for GCB BYOSA to clone policy source repo. I got a permission error when deploying until i added viewer role.
| ``` | ||
| --impersonate-service-account=terraform-org-sa@<SEED_PROJECT_ID>.iam.gserviceaccount.com | ||
| ``` | ||
|
|
||
| to run the command as the Terraform Service Account. | ||
|
|
||
| ### Deploying with Jenkins |
There was a problem hiding this comment.
In a follow up lets move jenkins docs to below local deploy.
bharathkkb
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor Cloud Build deploy instructions to follow the same structure of the manual and Jenkins deploys
also fixes #817