Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add groups creation #757

Merged
merged 15 commits into from
Aug 9, 2022
Merged

Feature/add groups creation #757

merged 15 commits into from
Aug 9, 2022

Conversation

mauro-cit
Copy link
Contributor

Fixes #676

Some notes about the changes done by this PR:

  • Added a new custom module inside 0-bootstrap step responsible by creating all the Required and Optional Google Identity Groups
  • On the 0-bootstrap step main.tf it was added the call to this module
  • A provider configuration setting a billing project is needed in order to be able to use this module
  • The instructions to perform the Automatic Groups creation was added to the Readme

@mauro-cit mauro-cit marked this pull request as ready for review July 15, 2022 19:32
@mauro-cit mauro-cit requested review from a team, rjerrems and bharathkkb as code owners July 15, 2022 19:32
bharathkkb
bharathkkb reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mauro-cit

0-bootstrap/main.tf Outdated Show resolved Hide resolved
0-bootstrap/modules/groups/variables.tf Outdated Show resolved Hide resolved
0-bootstrap/modules/groups/variables.tf Outdated Show resolved Hide resolved
0-bootstrap/modules/groups/variables.tf Outdated Show resolved Hide resolved
0-bootstrap/main.tf Outdated Show resolved Hide resolved
0-bootstrap/modules/groups/outputs.tf Outdated Show resolved Hide resolved
0-bootstrap/provider.tf Outdated Show resolved Hide resolved
@mauro-cit mauro-cit requested a review from bharathkkb July 26, 2022 13:26
bharathkkb
bharathkkb approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

@mauro-cit mauro-cit self-assigned this Aug 9, 2022
bharathkkb
bharathkkb approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI error is unrelated

@bharathkkb bharathkkb merged commit 5d9f867 into terraform-google-modules:master Aug 9, 2022
@release-please release-please bot mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems

Assignees

@mauro-cit mauro-cit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provision groups via TF
2 participants
@mauro-cit @bharathkkb