Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GAR in infra pipelines and test for artifact register #395

Merged
merged 18 commits into from
Apr 9, 2021
Merged

Adding GAR in infra pipelines and test for artifact register #395

merged 18 commits into from
Apr 9, 2021

Conversation

renato-rudnicki
Copy link
Contributor

@renato-rudnicki renato-rudnicki commented Mar 26, 2021 •
edited
Loading

  • Added fix for issue 377
  • Added test for artifact register creation
  • Tested with step-5
  • Added additional API's to base projects
  • Added additional roles to base project service account.

@bharathkkb
Copy link
Member

we recently merged develop into main, please switch base to main branch and rebase

@renato-rudnicki renato-rudnicki changed the base branch from develop to master April 5, 2021 21:39
@renato-rudnicki renato-rudnicki changed the title [DRAFT] - Adding GAR in infra pipelines and test for artifact register Adding GAR in infra pipelines and test for artifact register Apr 8, 2021
@renato-rudnicki renato-rudnicki marked this pull request as ready for review April 8, 2021 19:58
@renato-rudnicki renato-rudnicki requested review from bharathkkb, rjerrems and a team as code owners April 8, 2021 19:58
@renato-rudnicki
Copy link
Contributor Author

Rebased with master

bharathkkb
bharathkkb reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some minor questions

4-projects/business_unit_1/shared/variables.tf Show resolved Hide resolved
4-projects/modules/infra_pipelines/variables.tf Outdated Show resolved Hide resolved
4-projects/business_unit_2/development/example_base_shared_vpc_project.tf Show resolved Hide resolved
@daniel-cit daniel-cit requested a review from bharathkkb April 9, 2021 03:51
@bharathkkb bharathkkb merged commit 2a2e4fe into terraform-google-modules:master Apr 9, 2021
@daniel-cit daniel-cit mentioned this pull request Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cit daniel-cit daniel-cit left review comments

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renato-rudnicki @bharathkkb @daniel-cit