Update main.tf service to GA
#699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct VPC egress for Cloud Run services is now GA: https://cloud.google.com/run/docs/release-notes#April_24_2024 We should update the sample file's launch stage accordingly.
- Sample doesn't need `ALL_TRAFFIC` - Name is invalid
|
hey @bobfuru I updated the source template that generates these here GoogleCloudPlatform/magic-modules#10524 |
|
Thanks, @iennae - I'll close my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct VPC egress for Cloud Run services is now GA: https://cloud.google.com/run/docs/release-notes#April_24_2024
We should update the sample file's launch stage accordingly.