-
Notifications
You must be signed in to change notification settings - Fork 0
feat(policy): add workflow baseline and pinning guidance #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @anmolnagpal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new policy document, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable workflow baseline policy document. The guidelines for reusable workflows, pull requests, and Terraform modules are clear and promote good CI/CD hygiene. I have one suggestion to enhance the clarity and security of the reusable workflow reference policy regarding immutable tags.
WORKFLOW_BASELINE.md
Outdated
| - immutable release tag. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start for a workflow policy. To make the guidance on 'immutable release tag' more robust, it would be beneficial to explain how to ensure a tag is immutable. Standard git tags can be moved (force-pushed), which would make them a 'floating ref' again. Adding a note about using GitHub Releases and protected tags provides actionable advice and reduces ambiguity.
| - immutable release tag. | |
| - immutable release tag. | |
| **Note:** To be truly immutable, use tags from GitHub Releases and consider protecting them in repository settings, as standard git tags can be moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — clarified the guidance to call out GitHub Releases + protected tags so refs remain immutable in practice.
|
[gemini-followup-2026-02-09] Disposition: resolved / non-blocking for this branch.
|
|
[gemini-followup-2026-02-09] |
Summary\n- add org baseline policy doc for reusable workflow pinning\n- document immutable SHA/tag requirement for reusable workflows\n- document Terraform module baseline expectations ( + )\n\n## Severity\n- Medium: org CI/workflow hygiene\n\n## Migration Notes\n- Documentation-only change.