feat: Allow setting vpc endpoints as an input for each endpoint #1056
Conversation
modules/vpc-endpoints/main.tf
Outdated
| @@ -24,7 +24,7 @@ resource "aws_vpc_endpoint" "this" { | |||
| for_each = local.endpoints | |||
|
|
|||
| vpc_id = var.vpc_id | |||
| service_name = data.aws_vpc_endpoint_service.this[each.key].service_name | |||
| service_name = try(each.value.service_endpoint_url, data.aws_vpc_endpoint_service.this[each.key].service_name) | |||
There was a problem hiding this comment.
How service_endpoint_url should look for the FIPS environment?
There was a problem hiding this comment.
Sorry, I wasn't clear on this, I meant more so in the context of since you can override with inputs, users can use fips endpoints
You'd probably able to do it with this module if we added another data "aws_vpc_endpoint_service" with different filters, but It doesn't seem like a super common enough request.
There was a problem hiding this comment.
I see. I think it should be named service_endpoint instead of service_endpoint_url to represent the actual type of the expected value. Could you change it and I will merge it? :)
There was a problem hiding this comment.
Sure, no problem.
modules/vpc-endpoints/main.tf
Outdated
| @@ -24,7 +24,7 @@ resource "aws_vpc_endpoint" "this" { | |||
| for_each = local.endpoints | |||
|
|
|||
| vpc_id = var.vpc_id | |||
| service_name = data.aws_vpc_endpoint_service.this[each.key].service_name | |||
| service_name = try(each.value.service_endpoint_url, data.aws_vpc_endpoint_service.this[each.key].service_name) | |||
There was a problem hiding this comment.
I see. I think it should be named service_endpoint instead of service_endpoint_url to represent the actual type of the expected value. Could you change it and I will merge it? :)
## [5.7.0](v5.6.0...v5.7.0) (2024-03-22) ### Features * Allow setting vpc endpoints as an input for each endpoint ([#1056](#1056)) ([9163310](9163310))
|
This PR is included in version 5.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds feature to allow overriding for each
aws_vpc_endpointservice_nameproperty, but defaulting to data if not defined.Additionally this allows users to use specify fips endpoints if needed.
Motivation and Context
fixes #1054
Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestHave a PR here for an example where this was tested using changes in my
.terraformdirectory which I replicated in this fork.defenseunicorns/terraform-aws-vpc#113