Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add conditional null for sqs_managed_sse_enabled #41

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

bendehaan
Copy link
Contributor

Description

Conditionally set the variable sqs_managed_sse_enabled to null as setting this variable to anything else conflicts with the kms_master_key_id.

Motivation and Context

Closes #40

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s) - N.A.
  • I have tested and validated these changes using one or more of the provided examples/* projects - Ran the full suite
  • I have executed pre-commit run -a on my pull request

@bendehaan bendehaan changed the title fix: add conditional null for sqs_managed_sse_enabled Fix: add conditional null for sqs_managed_sse_enabled Oct 4, 2022
@bendehaan bendehaan changed the title Fix: add conditional null for sqs_managed_sse_enabled fix: Add conditional null for sqs_managed_sse_enabled Oct 4, 2022
@antonbabenko antonbabenko merged commit da544b9 into terraform-aws-modules:master Oct 4, 2022
antonbabenko pushed a commit that referenced this pull request Oct 4, 2022
### [3.4.1](v3.4.0...v3.4.1) (2022-10-04)

### Bug Fixes

* Add conditional null for sqs_managed_sse_enabled ([#41](#41)) ([da544b9](da544b9))
@antonbabenko
Copy link
Member

This PR is included in version 3.4.1 🎉

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS Key: Conflicting configuration arguments after introduction of sqs_managed_sse_enabled
3 participants