feat: Add timeouts configuration options #229
Conversation
nmalarenko
force-pushed
the
add-timeout
branch
from
88f51ed to
6c75ae6
Compare
Adding possibility to use timeouts option for aws_security_group resource
nmalarenko
force-pushed
the
add-timeout
branch
from
6c75ae6 to
5d64d50
Compare
nmalarenko
changed the title
There was a problem hiding this comment.
Looks pretty good. Could you change variables to be create_timeout and delete_timeout to be closer to other module where this is implemented already - ALB, and update code in examples/complete.
examples/complete/main.tf
Outdated
| description = "Security group with modified timeouts" | ||
| vpc_id = data.aws_vpc.default.id | ||
|
|
||
| create_timeout = "15m" |
There was a problem hiding this comment.
There is no need to have a separate example for this feature, but rather add ..._timeout = "..." argument to an existing complete_sg.
There was a problem hiding this comment.
Sorry that I was not clear about this in the previous comment.
There was a problem hiding this comment.
fair enough. fixed
There was a problem hiding this comment.
no worries, it was my bad :)
nmalarenko
force-pushed
the
add-timeout
branch
from
52d93c4 to
dc4eede
Compare
|
Great job! v4.4.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adding possibility to use timeouts option for
aws_security_groupresourcehttps://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group#timeouts
Motivation and Context
terraform destroycommand can fail with the error-messageDependencyViolation: resource sg-123 has a dependent objectdue to Lanbda ENIs. According to terraform documentation Lambda ENIs can take up to 45 minutes to delete. However timeouts feature is not available in current module.Fixes #228
Breaking Changes
no breaking changes
How Has This Been Tested?
I have tested it on my local project by getting the module from my fork. I set only timeout_delete value to 45m.
timeout_create used default value. The security groups were successfully created and destroyed