Skip to content

feat!: Increase Terraform and AWS provider minimum supported versions; update auth configuration schema #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2023
Merged

feat!: Increase Terraform and AWS provider minimum supported versions; update auth configuration schema #17

merged 8 commits into from
Jun 9, 2023

Conversation

ElementTech
Copy link
Contributor

@ElementTech ElementTech commented Apr 2, 2023 •
edited by bryantbiggs
Loading

Description

  • Update Terraform minimum supported version to 1.0
  • Update AWS provider minimum supported version to 5.0
  • The manner in which authentication is configured has changed - previously auth settings were provided under secrets in conjunction with auth_scheme and iam_auth variables. Now, auth settings are provided under the auth variable for multiple auth entries.
  • See the UPGRADE-3.0.md guide for further details

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ElementTech ElementTech changed the title ➕ add client_password_auth_type for the auth map block feat: add client_password_auth_type for the auth map block Apr 2, 2023
@ElementTech ElementTech changed the title feat: add client_password_auth_type for the auth map block feat: Add client_password_auth_type for the auth map block Apr 2, 2023
@amitai-devops
📝 add examples
821a524 
modified:   examples/postgresql_iam_cluster/main.tf; modified:   examples/postgresql_iam_instance/main.tf
@amitai-devops
🔧 add to variables
a3a21db 
modified:   variables.tf
@AlKapkone
Copy link
Contributor

@antonbabenko Could you please take a look, because it's very important for me too. Thanks a lot, sorry to bother you.

antonbabenko
antonbabenko requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_password_auth_type was introduced in v4.55.0 of Terraform AWS provider, so versions.tf should be updated in all places to reflect this.

At the same time, we can upgrade terraform version to be >= 1.0. Will you be able to update it? This will become a major release.

@antonbabenko antonbabenko changed the title feat: Add client_password_auth_type for the auth map block feat!: Add client_password_auth_type for the auth map block Jun 5, 2023
@AlKapkone
Copy link
Contributor

@amitai-devops @jatalocks Hi guys.
Do you need help from me to update this MR?

@ElementTech
Copy link
Contributor Author

@amitai-devops @jatalocks Hi guys.
Do you need help from me to update this MR?

Hey, I'm the same person, just two accounts 😅, I can get to it when I can but I wouldn't say no if someone wants to commit to this PR

@AlKapkone
Copy link
Contributor

@jatalocks Merge please, I hope this helps to merge these changes to the original module.
ElementTech#1

@AlKapkone
updated versions.tf (#1)
c5c117c 
Co-authored-by: Orest Kapko <orest.kapko@welltech.com>
@AlKapkone
Copy link
Contributor

@antonbabenko Hi, we updated MR. Do you know if we need anything else to add?

antonbabenko
antonbabenko requested changes Jun 8, 2023
View reviewed changes
@antonbabenko antonbabenko changed the title feat!: Add client_password_auth_type for the auth map block feat!: Bump Terraform version to 1.0+, added client_password_auth_type for the auth map block Jun 8, 2023
@AlKapkone
updated versions.tf (#2)
1007d28 
Co-authored-by: Orest Kapko <orest.kapko@welltech.com>
@bryantbiggs
Copy link
Member

@AlKapkone I'll update the examples since we've have a number of module changes - one sec

@AlKapkone
Copy link
Contributor

AlKapkone commented Jun 8, 2023 •
edited
Loading

@AlKapkone I'll update the examples since we've have a number of module changes - one sec

@bryantbiggs I tried to update the vpc module to the version = "~> 4.0". Do we need something else to update in examples?
I prepared a new MR to the fork repo - ElementTech#3

@bryantbiggs bryantbiggs changed the title feat!: Bump Terraform version to 1.0+, added client_password_auth_type for the auth map block feat!: Increase Terraform and AWS provider minimum supported versions; update auth configuration schema Jun 8, 2023
@bryantbiggs
Copy link
Member

Validated on mysql-iam-cluster and mysql-iam-instance which should also cover the postgresql equivalents as well

@antonbabenko please take a look when you get a chance

antonbabenko
antonbabenko approved these changes Jun 8, 2023
View reviewed changes
antonbabenko
antonbabenko reviewed Jun 8, 2023
View reviewed changes
@AlKapkone
Copy link
Contributor

@jatalocks Merge, please

@ElementTech
Copy link
Contributor Author

@jatalocks Merge, please

I am waiting for maintainer to merge, I'm not a maintainer

@AlKapkone
Copy link
Contributor

@antonbabenko Do we need something else to add or we can merge it?

@bryantbiggs bryantbiggs merged commit cc39e9d into terraform-aws-modules:master Jun 9, 2023
antonbabenko pushed a commit that referenced this pull request Jun 9, 2023
@semantic-release-bot
chore(release): version 3.0.0 [skip ci]
cb79f9c 
## [3.0.0](v2.1.2...v3.0.0) (2023-06-09)

### ⚠ BREAKING CHANGES

* Increase Terraform and AWS provider minimum supported versions; update `auth` configuration schema (#17)

### Features

* Increase Terraform and AWS provider minimum supported versions; update `auth` configuration schema ([#17](#17)) ([cc39e9d](cc39e9d))
@antonbabenko
Copy link
Member

This PR is included in version 3.0.0 🎉

@AlKapkone
Copy link
Contributor

Thanks so much for your efforts!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlKapkone AlKapkone AlKapkone approved these changes

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ElementTech @AlKapkone @bryantbiggs @antonbabenko @amitai-devops