-
-
Notifications
You must be signed in to change notification settings - Fork 715
feat: Add buildx and multi-stage build support to docker-build module #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add buildx and multi-stage build support to docker-build module #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
@@ -123,6 +123,9 @@ module "docker_build_from_ecr" { | |||
build_args = { | |||
FOO = "bar" | |||
} | |||
# Can also use buildx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add one more Terraform example showing buildx and multi-stage builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thank you!
## [7.21.0](v7.20.3...v7.21.0) (2025-05-16) ### Features * Add buildx and multi-stage build support to docker-build module ([#679](#679)) ([29893ab](29893ab))
This PR is included in version 7.21.0 🎉 |
Description
builder
andbuild_target
fordocker-build
moduleMotivation and Context
Buildx and multi-stage images are great. Let's use them!
Breaking Changes
I believe these are backwards compatible
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request