Skip to content

Conversation

kbrockhoff
Copy link
Contributor

@kbrockhoff kbrockhoff commented Jan 15, 2022

Description

Added flag for not including general tag map with the S3 object tags.

Motivation and Context

Fixes #249

Breaking Changes

None. New variable uses default value which results in current behavior if not explicitly set.

How Has This Been Tested?

Ran terraform plan on example projects.

@kbrockhoff kbrockhoff changed the title Added flag to exclude general tags from S3 Object tagging. fix: added flag to exclude general tags from S3 Object tagging Jan 15, 2022
@kbrockhoff kbrockhoff changed the title fix: added flag to exclude general tags from S3 Object tagging fix: Added flag to exclude general tags from S3 Object tagging. Jan 15, 2022
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that there is a limit in S3 object tags. :) Please make CI green and I will merge this one. Thank you very much!

@antonbabenko antonbabenko changed the title fix: Added flag to exclude general tags from S3 Object tagging. feat: Added flag to exclude general tags from S3 Object tagging. Jan 17, 2022
@antonbabenko antonbabenko changed the title feat: Added flag to exclude general tags from S3 Object tagging. feat: Added flag to exclude general tags from S3 Object tagging Jan 17, 2022
@antonbabenko antonbabenko merged commit a8a185c into terraform-aws-modules:master Jan 17, 2022
@antonbabenko
Copy link
Member

Thanks, @kbrockhoff for this PR!

antonbabenko pushed a commit that referenced this pull request Jan 17, 2022
## [2.32.0](v2.31.0...v2.32.0) (2022-01-17)

### Features

* Added flag to exclude general tags from S3 Object tagging ([#250](#250)) ([a8a185c](a8a185c))
@antonbabenko
Copy link
Member

This PR is included in version 2.32.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 Object Put fails when tags map contains more than 10 tags

2 participants