aws_iam_policy_attachment used for additional policies

[Ewande]

aws_iam_policy_attachment creates exclusive attachments, I think it makes more sense to use aws_iam_role_policy_attachment in those cases:

terraform-aws-lambda/iam.tf

Line 226 in 5ab6ccb

resource "aws_iam_policy_attachment" "additional_one" {

terraform-aws-lambda/iam.tf

Line 238 in 5ab6ccb

resource "aws_iam_policy_attachment" "additional_many" {

[codeninja55]

This should be the case for all attachments as it can override or removing existing policies from other roles.

[Ewande]

As far as I can see, these two are the only ones that allow using existing policies. Other attachments either create new policies or use inline policies.

[jasonhuling]

I just ran into this issue as well... does anyone know if there are any plans to correct this?

[antonbabenko]

I agree, it makes sense, fixed in #45, v1.20.0 has been just released.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.