Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added variable for TLS messaging in SQS queue from karpenter submodule #3312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Puig99
Copy link

@Puig99 Puig99 commented Feb 26, 2025

Description

Added a the bool variable queue_enforce_tls_messages for the karpenter submodule. It enforces the usage of TLS messaging in the SQS queue

Motivation and Context

I, like many of the users of this modules use them in a work environment. This change helps reaching compliance for security requirements in a corporative environment, allowing the SQS policy to only allow TLS messages in the queue

Breaking Changes

This change is not a breaking change, as it only introduces a not required variable, by default set as false.

How Has This Been Tested?

  • [ x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ x] I have tested and validated these changes using one or more of the provided examples/* projects
    I deployed the changes on my own deployment of the karpenter submodule. Then tested it by launching a plan on the example folder.
  • [ x] I have executed pre-commit run -a on my pull request

@Puig99 Puig99 changed the title Added variable for TLS messaging in SQS queue from karpenter submodule feat: Added variable for TLS messaging in SQS queue from karpenter submodule Feb 26, 2025
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 29, 2025
@bryantbiggs
Copy link
Member

why is this needed? there isn't anything sensitive in these messages, they are just capturing and forwarding EC2 events

@github-actions github-actions bot removed the stale label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants