Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Eliminates null check on tag values to fix for_each error about unknown *keys* #3119

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: Eliminates null check on tag values to fix for_each error about unknown *keys* #3119

merged 1 commit into from
Aug 9, 2024

Conversation

lorengordon
Copy link
Contributor

@lorengordon lorengordon commented Aug 9, 2024 •
edited
Loading

Description

See linked issue #3118

Motivation and Context

Fixes #3118

Related #2760
Related #2681
Related #2337

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@lorengordon lorengordon changed the title Eliminates null check on tag values to fix for_each error about unknown *keys* fix: Eliminates null check on tag values to fix for_each error about unknown *keys* Aug 9, 2024
bryantbiggs
bryantbiggs approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to try this

@bryantbiggs bryantbiggs merged commit 6124a08 into terraform-aws-modules:master Aug 9, 2024
20 of 21 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 9, 2024
@semantic-release-bot
chore(release): version 20.22.1 [skip ci]
faa42df 
## [20.22.1](v20.22.0...v20.22.1) (2024-08-09)

### Bug Fixes

* Eliminates null check on tag values to fix for_each error about unknown *keys* ([#3119](#3119)) ([6124a08](6124a08)), closes [#3118](#3118) [#2760](#2760) [#2681](#2681) [#2337](#2337)
@antonbabenko
Copy link
Member

This PR is included in version 20.22.1 🎉

@lorengordon
Copy link
Contributor Author

Confirmed everything is working for us, using Terraform 1.5.7! Thanks!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using terraform <1.6.0, aws_ec2_tag with dynamic tag *values* results in for_each error about unknown *keys*
3 participants
@lorengordon @antonbabenko @bryantbiggs