fix: Ensure vpc-cni is installed before adding nodes to the cluster (Manag…

[ChauAnhTuan]

Ensure vpc-cni is installed before adding nodes to the cluster (Managed nodegroup)

Description

The aws_eks_node_group resource must wait for vpc-cni or add-on to be added before adding the node group to the cluster.

Add depend_on to aws_eks_node_group resource (modules/eks-managed-node-group) with variable module_depends_on. On main module, set aws_eks_addon.before_compute as depend

Motivation and Context

Resolves Add depends_on for the 'resource "aws_eks_addon" "before_compute"' #3114

Breaking Changes

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[ChauAnhTuan]

[ChauAnhTuan]

Usedata of the EKS node group. I have tested it, and it works well.

  kubelet:
    config:
      maxPods: 110
      clusterDNS:
      - 172.20.0.10

[bryantbiggs]

we already have this supported today

terraform-aws-eks/main.tf

Lines 527 to 531 in 5fe865e

	depends_on = [
	module.fargate_profile,
	module.eks_managed_node_group,
	module.self_managed_node_group,
	]

[ChauAnhTuan]

we already have this supported today

terraform-aws-eks/main.tf

Lines 527 to 531 in 5fe865e

	depends_on = [
	module.fargate_profile,
	module.eks_managed_node_group,
	module.self_managed_node_group,
	]

Above "depdens_on" ensures the EKS node group is created before the add-ons. But with this resource, there is no "depends_on" that ensures no EKS node group has been created

terraform-aws-eks/main.tf

Line 536 in 5fe865e

resource "aws_eks_addon" "before_compute" {

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.