feat: Enable support for ignore_failed_scaling_activities #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
ivankatliarchuk
changed the title
ivankatliarchuk
changed the title
bryantbiggs
requested changes
Jul 19, 2024
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
bryantbiggs
approved these changes
Jul 19, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Jul 19, 2024
## [20.20.0](v20.19.0...v20.20.0) (2024-07-19) ### Features * Enable support for ignore_failed_scaling_activities ([#3104](#3104)) ([532226e](532226e))
|
This PR is included in version 20.20.0 🎉 |
Argote-Gustavo-bah
pushed a commit
to navwar-seastar/terraform-aws-eks
that referenced
this pull request
Jul 23, 2024
…aws-modules#3104) * feat(issue-3102): added support for ignore_failed_scaling_activities Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * Update node_groups.tf Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> * Update modules/self-managed-node-group/variables.tf Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> * feat(issue-3102): pre-commit checks sorted Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> --------- Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Argote-Gustavo-bah
pushed a commit
to navwar-seastar/terraform-aws-eks
that referenced
this pull request
Jul 23, 2024
## [20.20.0](terraform-aws-modules/terraform-aws-eks@v20.19.0...v20.20.0) (2024-07-19) ### Features * Enable support for ignore_failed_scaling_activities ([terraform-aws-modules#3104](terraform-aws-modules#3104)) ([532226e](terraform-aws-modules@532226e))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
ignore_failed_scaling_activities. No breaking changes for current clusters, as default value is set tofalseMotivation and Context
Our setup
So what is happening?
Error: waiting for Auto Scaling Group (eks-group1-1.27-asfsdfasdf) capacity satisfied: timeout while waiting for state to become 'ok' (last state: 'want exactly 44 healthy instance(s) in Auto Scaling Group, have 45', timeout: 10m0signore_failed_scaling_activities#3102Breaking Changes
It should not break anything
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request