Skip to content

Conversation

max-rocket-internet
Copy link
Contributor

@max-rocket-internet max-rocket-internet commented Sep 12, 2018

PR o'clock

Description

Cosmetic syntax changes to improve readability. Credit goes to @strygin for the inspiration.

2 changes:

  • Remove lookup function when no default is required to just refer to the map and key like this map["key"]. This reduces the () which improves readability.
  • Where possible, use an actual map instead of using the map function. e.g. {key = "value"}

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI)
  • Docs have been updated using terraform-docs per README.md instructions
  • I've added my change to CHANGELOG.md
  • Any breaking changes are highlighted above

@max-rocket-internet
Copy link
Contributor Author

Hey @brandoconnor could you review this PR? Ta.

Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonjbjelland
Copy link
Contributor

Looks like fmt is failing against workers.tf. Run that quick and this should be good to ship.

@max-rocket-internet
Copy link
Contributor Author

Ahh yeah. I tried a rebase and then manual edit in Gitkraken and it left some blank lines.

@max-rocket-internet max-rocket-internet merged commit fdd44c8 into terraform-aws-modules:master Sep 25, 2018
@max-rocket-internet max-rocket-internet deleted the cosmetic_fixes branch September 25, 2018 10:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants