Skip to content

Conversation

brandonjbjelland
Copy link
Contributor

@brandonjbjelland brandonjbjelland commented Jun 11, 2018

PR o'clock

Description

KOPS allows for creating multiple worker autoscaling groups each with different specifications (e.g. instance_type, asg size, userdata). This change allows for that same use case while still providing a default worker ASG if none are given. Security group IDs can also be provided for both workers and the cluster for better control over these aspects of the set up.

This finishes out the work of #12

While no more variable inputs are needed or any changed that are required, this is a breaking change as input for workers now takes on a new form.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features) - I'd like to have 2 sets of tests here, one that tests a barebones instantiation of the module and another that provides the kitchen sink worth of extra options.
  • Test results are pasted in this PR (in lieu of CI)
  • Docs have been added/updated (for bug fixes/features)
  • Any breaking changes are noted in the description above

@brandonjbjelland
Copy link
Contributor Author

Also wraps up: #11

@brandonjbjelland brandonjbjelland merged commit bc80724 into master Jun 11, 2018
@brandonjbjelland brandonjbjelland deleted the NextDeveloperTeam-add-worker-groups branch June 11, 2018 22:57
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants