Change "count" variable name to permit future Terraform feature?

[apparentlymart]

Hello!

This module defines a variable called count:

terraform-aws-ec2-instance/variables.tf

Lines 5 to 8 in 7a3aafb

	variable "count" {
	description = "Number of instances to launch"
	default = 1
	}

This is valid in current Terraform, but to implement hashicorp/terraform#953 will require this variable name to be reserved. We're currently hoping to make this name, along with for_each and lifecycle, reserved names that cannot be used for modules in preparation for them getting special meaning in a later release where that issue is implemented.

Would you be open to changing this variable name to be instance_count instead? Although we are not planning to implement count for modules immediately, we'd like to begin a deprecation cycle for use of this name as a variable so that the name is free for a change in a later release.

I noticed that terraform-aws-modules/rds/aws and terraform-aws-modules/elb/aws also have variables called count, for which I'd ask a similar question, but I didn't want to spam with loads of issues about the same thing.

Thanks!

[antonbabenko]

Martin, thanks for heads up!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.