Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instantiate default empty #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented Feb 5, 2024

Defaults the label as "-" since empty string or undefined is not allowed and developers may not want to use a label

@javiersuweijie
Copy link
Member

Should we just throw an error? Since a label is required and it is up to the dev to pick one. If it defaults to - then it might be successful even though the dev didn't know that a label should be set.

Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

Base automatically changed from feat/bank/supply_by_denom to main February 6, 2024 15:44
@emidev98
Copy link
Contributor Author

emidev98 commented Feb 6, 2024

Core will throw an error if the label is not set, so in order to make it easier for the dev that wants to setup a meaningless label we just default to "-" if the label is not provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants